Ecommerce software home
Shopping Cart Software Forum for Ecommerce Templates
 
Home | Profile | Register | Active Topics | Members | Search | FAQ
Username:
Password:
Save Password
Forgot your Password?

Find us on Facebook Follow us on Twitter View our YouTube channel
Search our site
Forum Search
Google Site Search
 All Forums
 Technical
 PHP (Unix / Linux / Apache) versions
 Side Filter 2 issue & fix...
Author « Topic »  

davcom1
Starting Member

United Kingdom
35 Posts

Pre-sales questions only
(More Details...)

Posted - 03/11/2019 :  09:35:52  
I noticed we had an issue where any content under the Side Filter would "collapse" in certain situations.

After a bit of trial and error, I identified the issue arises when the "more" button appears as the last filter.

Looks like there is an "=" sign missing on line 361 of incsidefilter.php

Changed from if($morebuttondisplayed) $outtxt . '</div>';

To if($morebuttondisplayed) $outtxt .= '</div>';

Hope that helps!

David

Edited by - davcom1 on 03/11/2019 09:36:35

Andy
ECT Moderator

95440 Posts

Posted - 03/11/2019 :  09:42:13  
Hi David

Thanks for the heads up but so I can recreate it here http://ectwp.com/product/ can you explain this bit if you have a moment
quote:
I identified the issue arises when the "more" button appears as the last filter.
What do you mean there by the last filter? Use the demo there if it helps explain.

Andy

Please feel free to review / rate our software

davcom1
Starting Member

United Kingdom
35 Posts

Pre-sales questions only
(More Details...)

Posted - 03/11/2019 :  10:02:29  
Hi Andy,

On your demo page, you have "Sports" with the "more" button.

If you adjust the order of your filter groups so that "Sports" is the lowest in the list this should replicate the issue...

It seems that without the "=" after the "." (concatenating assignment) on line 361 of incsidefilter.php, the closing </div> doesn't get added to that section.

I can send a link to examples at my end but it would need to be private as I've got the dev site folder password protected.

Regards,

David

Andy
ECT Moderator

95440 Posts

Posted - 03/11/2019 :  10:13:41  
Thanks, I tried that and it seems fine there. This is what I am using in includes.php

$GLOBALS['filterpricebands']=50;
$GLOBALS['sidefilterstyle']='multiple';
$GLOBALS['displayzeroattributes']=TRUE;
$GLOBALS['sfpricebuttoninline']=TRUE;
$GLOBALS['sidefiltermorebutton']=TRUE;
//$GLOBALS['imgsidefiltermore']='link';
$GLOBALS['sidefiltermoreat']=4;

I just commented out the 'link' to see if that made any difference but it didn't. Do you have something similar?

Andy

Please feel free to review / rate our software

davcom1
Starting Member

United Kingdom
35 Posts

Pre-sales questions only
(More Details...)

Posted - 03/12/2019 :  01:16:54  
Hi Andy,

I think your demo page is doing the same thing but not with so much visual impact.

If you look carefully, your "minicart" on the side is now part of the side filter. The tell-tale is the extra "border-bottom" line showing under the "keyword search".

If you add the "equals" sign to line 361 of your sidefilter.php (v2) and refresh the page, you should see a subtle difference.

And/or change the background-color css for .widget-wrapper to #000 to see a lot more clearly.

Kind regards,

David

Andy
ECT Moderator

95440 Posts

Posted - 03/12/2019 :  01:26:25  
Good catch David, I missed that yesterday - I also see the footer section is out of whack now too.

Andy

Please feel free to review / rate our software

davcom1
Starting Member

United Kingdom
35 Posts

Pre-sales questions only
(More Details...)

Posted - 03/12/2019 :  01:40:51  
Yes, the change is a lot more subtle on your test page!

Honestly, its just the missing equals sign after the dot on line 361 which leaves a <div> open and then has a knock-on effect.


Edited by - davcom1 on 03/12/2019 01:41:32

Vince
Administrator

42874 Posts

Posted - 03/12/2019 :  02:53:09  
Hi David
Thanks a lot for letting us know and I've fixed this in the source now.

Vince

Click Here for Shopping Cart Software
Click Here to sign up for our newsletter
Click Here for the latest updater

quadrant
Ecommerce Template Guru

United Kingdom
1110 Posts

Pre-sales questions only
(More Details...)

Posted - 03/12/2019 :  04:17:49  
Hi,

I have just downloaded my updaters to get this fix but I only received the following in the email:
php3minicss.zip
php3digidownloads.zip
phpupdater6.9.zip

Looking back I purchased the Side Filter 2 in September last year and I have 12 months updaters too.

Please could you point me in the right direction to get the update so I can apply the fix Vince has kindly added this morning.

Regards,
David

Andy
ECT Moderator

95440 Posts

Posted - 03/12/2019 :  04:33:56  
Just sent you a mail, David (Quadrant)

Andy

Please feel free to review / rate our software

quadrant
Ecommerce Template Guru

United Kingdom
1110 Posts

Pre-sales questions only
(More Details...)

Posted - 03/12/2019 :  04:40:39  
Thanks Andy.

Regards,
David
  « Topic »  
Jump To:
Shopping Cart Software Forum for Ecommerce Templates © 2002-2022 ecommercetemplates.com
This page was generated in 0.02 seconds. Snitz Forums 2000