Ecommerce software home
Shopping Cart Software Forum for Ecommerce Templates
 
Home | Profile | Register | Active Topics | Members | Search | FAQ
Username:
Password:
Save Password
Forgot your Password?

Find us on Facebook Follow us on Twitter View our YouTube channel
Search our site
Forum Search
Google Site Search
Author « Topic »  

John M
Advanced Member

459 Posts

Pre-sales questions only
(More Details...)

Posted - 09/05/2021 :  06:19:36  
Line 400 and 1454 in inccart.php has a typo and the selector doesn't work:
[code]<label class="ectlabel" class="shipradio">[/code]

I assume it should be:
[code]<label class="ectlabel shipradio">[/code]

John

Edited by - John M on 09/05/2021 06:22:23

Marshall
Ecommerce Template Guru

USA
1916 Posts

Posted - 09/05/2021 :  06:31:18  
I think it should just be class="ectlabel" as the input has class="shipradio" assigned to it. If you check the ectcart.css, you will see input.shipradio {vertical-align:text-bottom;margin-right:5px;}.

What it should probably be.
<label class="ectlabel"><input type="radio" class="shipradio" value="'

Marshall
CENLYT Productions - ms designs
Affordable Web Design
Custom Ecommerce Designs
Responsive Websites
Cenlyt.com

John M
Advanced Member

459 Posts

Pre-sales questions only
(More Details...)

Posted - 09/05/2021 :  06:38:14  
I would assume not since that option does not allow for the label to have its own customised look and feel.

It would be much more preferable to have the choice to keep it standard or to customise:
<label class="ectlabel shipradio">

Having the choice should always be the case for all html elements otherwise they are impossible to select on their own and can have unintended consequences elsewhere.

John

Marshall
Ecommerce Template Guru

USA
1916 Posts

Posted - 09/05/2021 :  07:20:19  
Guess we have to wait for Vince.

Marshall
CENLYT Productions - ms designs
Affordable Web Design
Custom Ecommerce Designs
Responsive Websites
Cenlyt.com

Vince
Administrator

42874 Posts

Posted - 09/05/2021 :  14:54:02  
Hi All
Updaters have been updated with the fix in inccart.php, and I have to say, I think the correct way here is as John says which is...

<label class="ectlabel shipradio">

But that doesn't mean I'm taking sides as both are correct really.

Vince

Click Here for Shopping Cart Software
Click Here to sign up for our newsletter
Click Here for the latest updater
  « Topic »  
Jump To:
Shopping Cart Software Forum for Ecommerce Templates © 2002-2022 ecommercetemplates.com
This page was generated in 0.02 seconds. Snitz Forums 2000